----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43293/#review119262 -----------------------------------------------------------
src/docker/docker.cpp (line 382) <https://reviews.apache.org/r/43293/#comment180568> I would make this a LOG(WARNING) since we don't really expect this to happen at all with Mesos. src/docker/docker.cpp (line 391) <https://reviews.apache.org/r/43293/#comment180570> This also isn't an expected condition as well right? LOG(WARNING) will be more appropriate as well. Can you also log the image name? Same as above one. src/docker/docker.cpp (line 398) <https://reviews.apache.org/r/43293/#comment180569> Actually shouldn't we take the latest value? What does Docker do when it have duplicated env var? - Timothy Chen On Feb. 7, 2016, 9:40 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43293/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2016, 9:40 a.m.) > > > Review request for mesos, haosdent huang, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-4607 > https://issues.apache.org/jira/browse/MESOS-4607 > > > Repository: mesos > > > Description > ------- > > Ignored invalid env vars when creating docker image. > > > Diffs > ----- > > src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 > src/tests/containerizer/docker_tests.cpp > 620819330847a10d9dcd817968df9d2b180a9a29 > > Diff: https://reviews.apache.org/r/43293/diff/ > > > Testing > ------- > > make > make check > > $ GLOG_v=2 ./bin/mesos-tests.sh > --gtest_filter="DockerImageTest.ParseInspectonImage" --verbose > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from DockerImageTest > [ RUN ] DockerImageTest.ParseInspectonImage > I0207 10:30:01.894125 2034615040 process.cpp:2489] Spawned process > files@192.168.0.100:49551 > I0207 10:30:01.894136 211529728 process.cpp:2499] Resuming > files@192.168.0.100:49551 at 2016-02-07 02:30:01.894163968+00:00 > I0207 10:30:01.894317 210456576 process.cpp:2499] Resuming > help@192.168.0.100:49551 at 2016-02-07 02:30:01.894332928+00:00 > I0207 10:30:01.898862 2034615040 docker.cpp:397] Skipping duplicate > environment variable 'JAVA_VERSION' > I0207 10:30:01.898892 2034615040 docker.cpp:390] Skipping invalid environment > variable 'JAVA_VERSION+8u66' for 'ContainerConfig.Env' > I0207 10:30:01.899473 209920000 process.cpp:2499] Resuming > AuthenticationRouter(1)@192.168.0.100:49551 at 2016-02-07 > 02:30:01.899522048+00:00 > I0207 10:30:01.899983 213139456 process.cpp:2499] Resuming > files@192.168.0.100:49551 at 2016-02-07 02:30:01.900000000+00:00 > I0207 10:30:01.900032 213139456 process.cpp:2604] Cleaning up > files@192.168.0.100:49551 > I0207 10:30:01.900244 211529728 process.cpp:2499] Resuming > help@192.168.0.100:49551 at 2016-02-07 02:30:01.900256000+00:00 > [ OK ] DockerImageTest.ParseInspectonImage (8 ms) > [----------] 1 test from DockerImageTest (8 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (18 ms total) > [ PASSED ] 1 test. > > > Thanks, > > Guangya Liu > >
