> On Feb. 16, 2016, 11:46 p.m., Jie Yu wrote: > > src/slave/containerizer/docker.cpp, lines 473-488 > > <https://reviews.apache.org/r/43015/diff/7/?file=1241786#file1241786line473> > > > > There's a os::exists check in linux fs isolator which you removed. This > > is fine because we won't update volumes when containerizer->update is > > called. I think we should at least drop a TODO here > > so that we don't forget that when we want to support > > containerizer->update. > > > > Alternatively, we can kill updatePersistentVolumes and inline it into > > mountPersistentVolumes. > > Timothy Chen wrote: > I think I simply forgot about it, let me add them.
Actually I'll just drop a TODO since we don't support update as you mentioned. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43015/#review119340 ----------------------------------------------------------- On Feb. 16, 2016, 3:33 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43015/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2016, 3:33 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-3413 > https://issues.apache.org/jira/browse/MESOS-3413 > > > Repository: mesos > > > Description > ------- > > Fixed persistent volumes with docker tasks. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp 77a50d80179672cf3c270cbdd7fa003c7d9ad6f3 > src/slave/containerizer/docker.cpp ed1c9a551f03a37d572470e4c495f5df834198cc > src/tests/containerizer/docker_containerizer_tests.cpp > 645bdcf095145097d8b8c65d592c787417883145 > > Diff: https://reviews.apache.org/r/43015/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
