----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review119567 -----------------------------------------------------------
Patch looks great! Reviews applied: [43613, 43614, 43629, 43630, 43615] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Feb. 17, 2016, 10:34 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43615/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2016, 10:34 p.m.) > > > Review request for mesos, Bernd Mathiske and Artem Harutyunyan. > > > Bugs: MESOS-4633 and MESOS-4634 > https://issues.apache.org/jira/browse/MESOS-4633 > https://issues.apache.org/jira/browse/MESOS-4634 > > > Repository: mesos > > > Description > ------- > > Includes the following changes: > > * Added the `<process/owned.hpp>` header where appropriate. > * Added the namespace `using process::Owned;` where appropriate. > * Generally replaced `Try<PID<Master>>` with `Owned<cluster::Master>`. And > `Try<PID<Slave>>` with `Owned<cluster::Slave>`. > * Added the (now required) `MasterDetector` argument to all slaves. Before, > this was fetched from the first master in `Cluster`. > * Removed `Shutdown();` from all tests. > * Replaced `Stop(...)` with the appropriate master/slave destruction calls. > * Wrap various slave objects in `Owned` (i.e. containerizers, isolators, > launchers, etc). > * Replace `CHECK` in tests with `ASSERT`. > > > Diffs > ----- > > src/tests/authentication_tests.cpp 85f14c3d453ca5aeffa1c915f38fe3031c2cf712 > src/tests/container_logger_tests.cpp > 6e2b8c1b80d4b49a1042c53945c223785d0d4a3f > src/tests/containerizer/docker_containerizer_tests.cpp > 645bdcf095145097d8b8c65d592c787417883145 > src/tests/containerizer/external_containerizer_test.cpp > 8e1dbe306a088eb16cd3b9c6174b95fad5685da4 > src/tests/containerizer/filesystem_isolator_tests.cpp > d8c3c81c3d5a4c4093b3d4b27bb5c123c77accfc > src/tests/containerizer/isolator_tests.cpp > 653b037c489072f43e53dec01a811a9249dcd660 > src/tests/containerizer/memory_pressure_tests.cpp > 4a03af2c9c0643d964b1d76e2096341b59bf5dce > src/tests/containerizer/mesos_containerizer_tests.cpp > 15f0f93d2e5c19a22f6cc4a71a7d94be4aaec2c1 > src/tests/containerizer/port_mapping_tests.cpp > 1e6cb05144995c1cc12e3caa9825761fd9a0e21a > src/tests/credentials_tests.cpp 7edcc857e0f6f8e80e265deeec59d6349d392224 > src/tests/disk_quota_tests.cpp 413e562026a4fc9779f616e921ae2fa2ca51e012 > src/tests/exception_tests.cpp 6b71316d545e97f14a45daa14d0fd95204befd3b > src/tests/executor_http_api_tests.cpp > 36a042ed103271ca873450236f39a8152fbbf07e > src/tests/fault_tolerance_tests.cpp > 982468f851cd9d95eb6cde7c57f2d737d46a827c > src/tests/gc_tests.cpp 61a8abb9581dc4602b197a88a677b19386969cbf > src/tests/health_check_tests.cpp 59ef31970af2d255abe169dfbc2e6e0314d29e9a > src/tests/hook_tests.cpp 59a00ea722a17bbc82b14c69bda826f68cbac6e9 > src/tests/master_allocator_tests.cpp > cba7c36471f93b678d94e1da0251a28a893696b1 > src/tests/master_authorization_tests.cpp > 29c89fb11da792c3e71eb880a19657ea225b3cc8 > src/tests/master_contender_detector_tests.cpp > 255ab8119a04b55bb4f1b61dee19c4be64499376 > src/tests/master_maintenance_tests.cpp > b98eedec388813ee795dd83ccc5ff27338209475 > src/tests/master_quota_tests.cpp 8357ec911b2a158632a708ae3adff6eabc536697 > src/tests/master_slave_reconciliation_tests.cpp > d41178eb41df519073fc0890c5716bbc9fed6ad2 > src/tests/master_tests.cpp 393a6f5fe3744d6ba743f362b7e309d1ee75a303 > src/tests/master_validation_tests.cpp > 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 > src/tests/metrics_tests.cpp 106bea58b0714ae745df73597c702e4815523938 > src/tests/monitor_tests.cpp 869c9e032817e8859a968232d4a61556a3d53d45 > src/tests/oversubscription_tests.cpp > d4ae81972fd218c58a413d1968a4e9acbee52fd3 > src/tests/partition_tests.cpp c5badbe90e302793bfbf3f16373efe241decb7d5 > src/tests/persistent_volume_endpoints_tests.cpp > 6069ca1e9ed278459c5182e438417e95955b1924 > src/tests/persistent_volume_tests.cpp > e169e1b141a38dc389eefd42c11a078c413123d5 > src/tests/rate_limiting_tests.cpp caced732ded05a334861a53488ef6391885b2263 > src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64 > src/tests/registrar_zookeeper_tests.cpp > 3df9779ee5d076e16f6a538326693a36f986b6d0 > src/tests/repair_tests.cpp bb104562659e135492f9857e5b452c8a0a9e97da > src/tests/reservation_endpoints_tests.cpp > afe81b1d38a1b3a82583720f26482ddcde8f5e85 > src/tests/reservation_tests.cpp d2ef15934556cb879f31850d52712aec77231fc7 > src/tests/resource_offers_tests.cpp > 0bad45dd1dabecc88fef1ab46e8ea26718070b33 > src/tests/role_tests.cpp fc3a72894631279460ee7971a4627d73c3d8c351 > src/tests/scheduler_driver_tests.cpp > f6dc25d82ae5f1e77fc6ede7ff2660ed0d9ea039 > src/tests/scheduler_event_call_tests.cpp > bd8920fa9d5475e5f6533c8424ebff1588bfe645 > src/tests/scheduler_http_api_tests.cpp > 9eb1de7d9541395b92b951f0fe0ddbb2f219fe30 > src/tests/slave_recovery_tests.cpp e2a78a0f55b7657057ee351a747caff51024fd67 > src/tests/slave_tests.cpp c7f5a701eff2c2f9aa3df5722583a131bf2c072a > src/tests/status_update_manager_tests.cpp > d64d3b8c96270478f6b681c038de77c3a9eb68fe > src/tests/teardown_tests.cpp 5753559003d703138d2bbee6a1ac93473ba0b0c0 > > Diff: https://reviews.apache.org/r/43615/diff/ > > > Testing > ------- > > sudo make check > > | OSX | CentOS 7 | CentOS 6 | Debian 8 | Ubuntu 15.10 | Ubuntu 14 | > Ubuntu 12 | > Non-SSL | :) | & | :) | :) | :) | :) | > :) | > With-SSL | :) | & | :) | :) | x | :) | > :) | > > :) = Passed. > > Note: These are known flaky tests. > x = Failed: SlaveTests.StateEndpoint (appears to be a floating point issue) > & = Failed: > LinuxFilesystemIsolatorTest.ROOT_ImageInVolumeWithRootFilesystem, > LinuxFilesystemIsolatorTest.ROOT_MultipleContainers > > > Thanks, > > Joseph Wu > >
