----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/#review119669 -----------------------------------------------------------
src/linux/fs.hpp (lines 350 - 351) <https://reviews.apache.org/r/43718/#comment181010> Can you move this to the top? src/linux/fs.cpp (line 409) <https://reviews.apache.org/r/43718/#comment181012> Ditto on moving this to the top of this file. src/linux/fs.cpp (lines 411 - 412) <https://reviews.apache.org/r/43718/#comment181011> Ditto on using os::read here. - Jie Yu On Feb. 18, 2016, 4:01 p.m., Shuai Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43718/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2016, 4:01 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4707 > https://issues.apache.org/jira/browse/MESOS-4707 > > > Repository: mesos > > > Description > ------- > > Added fs::supported() function. > > > Diffs > ----- > > src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 > src/linux/fs.cpp 0df194207a66bf4c417349bebcc8912acbf5976e > src/tests/containerizer/fs_tests.cpp > 29e43877612fa151e6f6d79268a7411272a7bfeb > > Diff: https://reviews.apache.org/r/43718/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Shuai Lin > >