----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43271/ -----------------------------------------------------------
(Updated Feb. 19, 2016, 10:54 a.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till Toenshoff. Changes ------- Made `subprocess_environment` a private (static) function. Tweaked some comments. Bugs: MESOS-4609 https://issues.apache.org/jira/browse/MESOS-4609 Repository: mesos Description ------- * Adds a helper method for getting the current environment plus considerations for libprocess. * Changes the default behavior of `process::subprocess` to use the above helper when given `environment = None()`. * Adds a warning inside `process::subprocess` if `LIBPROCESS_PORT` conflicts with the current process's `LIBPROCESS_PORT`. Diffs (updated) ----- 3rdparty/libprocess/src/subprocess.cpp 44ca6d0869f3dbcfda1ac01d0d6b79dc20c4267c Diff: https://reviews.apache.org/r/43271/diff/ Testing ------- make Tests are run in the next review. Thanks, Joseph Wu