> On Feb. 20, 2016, 11:55 a.m., Ben Mahler wrote: > > include/mesos/mesos.proto, line 1109 > > <https://reviews.apache.org/r/43487/diff/3/?file=1241833#file1241833line1109> > > > > Let's clarify that "being killed" in this context is referring to the > > executor having received the kill request, for example: > > > > // The task is being killed by the executor, but is not yet killed.
Let's also reference the TASK_KILLING_STATE capability here so that it's clear in the API that this requires the framework to set a capability. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43487/#review120038 ----------------------------------------------------------- On Feb. 16, 2016, 9:51 a.m., Abhishek Dasgupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43487/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2016, 9:51 a.m.) > > > Review request for mesos, Ben Mahler and Qian Zhang. > > > Bugs: MESOS-4547 > https://issues.apache.org/jira/browse/MESOS-4547 > > > Repository: mesos > > > Description > ------- > > Add TASK_KILLING state. > > > Diffs > ----- > > include/mesos/mesos.proto 5d1a20b4ff647f43701a353472b56a4b74b6bbc3 > include/mesos/v1/mesos.proto 415a20d9f3385e9627635dd89d78c58d03e3c116 > src/master/http.cpp 3d7a624b78fd85a8d99bce609e37411ed660678c > src/master/master.hpp 3a7e18232323a1c051bcc97915484b1195fffe58 > src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22 > src/master/metrics.hpp 551e4eb0f910aa4ce28a2a955019108fcd3d6371 > src/master/metrics.cpp 5e4f4d352579dcd391a133600f9d4abc6b2402a7 > src/slave/metrics.hpp 2c22de521309806d70f9bd124359756b5e4c75b4 > src/slave/metrics.cpp 07694955d21efc2509e0eebcd0b5957249d13319 > src/slave/slave.hpp ced835dec797bcc5640422468487a4289a737e38 > src/slave/slave.cpp f0be0d5bf4b853952caf06e2e262c2903d79ead3 > src/tests/metrics_tests.cpp 106bea58b0714ae745df73597c702e4815523938 > > Diff: https://reviews.apache.org/r/43487/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Abhishek Dasgupta > >
