> On Feb. 18, 2016, 11:15 p.m., Jie Yu wrote: > > src/slave/containerizer/docker.cpp, line 785 > > <https://reviews.apache.org/r/33174/diff/3/?file=1165089#file1165089line785> > > > > Do you need to call update for this case (command task but agent is not > > running in a docker container)? > > Steve Niemitz wrote: > The command executor is a totally different code path, so calling update > wouldn't update the right thing. I'd like to handle that in a seperate > review since its more complicated. > > Jie Yu wrote: > Hum, why do you think it's a totally different code path? 'update' will > identify the correct container (the container launched by the command > executor) by calling docker inspect using container->name(). The way we > generate container name is a little implicit in the code. I think you can > just do an 'update' after launch the executor process similar to the custom > executor's case. Or am I missing something?
Yeah you're totally right! Thanks for clarifying that. I'll make the changes here too. That's awesome this should work for both code paths now. - Steve ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/#review119738 ----------------------------------------------------------- On Dec. 15, 2015, 8:14 p.m., Steve Niemitz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33174/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2015, 8:14 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-2617 > https://issues.apache.org/jira/browse/MESOS-2617 > > > Repository: mesos > > > Description > ------- > > Fix for docker containerizer not configuring CFS quotas correctly. > > It would be nice to refactor all this isolation code in a way that can be > shared between all containerizers, as this is basically just copied from the > CgroupsCpushareIsolator, but that's a much bigger undertaking. > > > Diffs > ----- > > src/slave/containerizer/docker.cpp 2d2dd4e0df36207c5f3cbb4fe2c50df51c0f3e9e > > Diff: https://reviews.apache.org/r/33174/diff/ > > > Testing > ------- > > > Thanks, > > Steve Niemitz > >
