> On Feb. 19, 2016, 9:28 a.m., haosdent huang wrote: > > src/tests/containerizer/fs_tests.cpp, line 49 > > <https://reviews.apache.org/r/43718/diff/3/?file=1258902#file1258902line49> > > > > I use CentOS 6. But seems don't have `ext2` and `ext3` in > > `/proc/filesystems` > > > > ``` > > at /proc/filesystems > > nodev sysfs > > nodev rootfs > > nodev bdev > > nodev proc > > nodev cgroup > > nodev cpuset > > nodev tmpfs > > nodev devtmpfs > > nodev binfmt_misc > > nodev debugfs > > nodev securityfs > > nodev sockfs > > nodev usbfs > > nodev pipefs > > nodev anon_inodefs > > nodev inotifyfs > > nodev devpts > > nodev ramfs > > nodev hugetlbfs > > iso9660 > > nodev pstore > > nodev mqueue > > ext4 > > vfat > > ``` > > Guangya Liu wrote: > I think that's why using EXPECT_SOME_TRUE here. The ubuntu does have this. > > haosdent huang wrote: > Yes, but this test case would fail in CentOS 6?
Good catch, I think that's because ext2 and ext3 modules are not loaded on your server by default. I removed "ext2" and "ext3" test, and added "rootfs" test. - Shuai ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/#review119845 ----------------------------------------------------------- On Feb. 21, 2016, 7:43 a.m., Shuai Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43718/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2016, 7:43 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4707 > https://issues.apache.org/jira/browse/MESOS-4707 > > > Repository: mesos > > > Description > ------- > > Added fs::supported() function. > > > Diffs > ----- > > src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 > src/linux/fs.cpp 0df194207a66bf4c417349bebcc8912acbf5976e > src/tests/containerizer/fs_tests.cpp > 29e43877612fa151e6f6d79268a7411272a7bfeb > > Diff: https://reviews.apache.org/r/43718/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Shuai Lin > >
