> On Feb. 22, 2016, 8:16 a.m., Michael Park wrote: > > docs/persistent-volume.md, line 56 > > <https://reviews.apache.org/r/43634/diff/1/?file=1252157#file1252157line56> > > > > Do you know if we actually have a good reason for the 8 space indent > > here as opposed to 4? I noticed that `docs/reservation.md` has 8 spaces as > > well, but I don't remember why I did that nor where I got it from :(
You are right 4 is enough and consistent with the markdown styleguide but not with other files (reservation, quota). I updated this file and follow up by making the other files consistent. - Joerg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43634/#review120127 ----------------------------------------------------------- On Feb. 16, 2016, 11:03 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43634/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2016, 11:03 p.m.) > > > Review request for mesos, Michael Park and Neil Conway. > > > Repository: mesos > > > Description > ------- > > Consistent markdown code style in persistent-volumes.md. > > > Diffs > ----- > > docs/persistent-volume.md 728854076595a0908a17d85482a7031acfbb09a0 > > Diff: https://reviews.apache.org/r/43634/diff/ > > > Testing > ------- > > > Thanks, > > Joerg Schad > >
