> On Feb. 23, 2016, 3:06 p.m., Bernd Mathiske wrote: > > 3rdparty/libprocess/src/libevent_poll.cpp, line 57 > > <https://reviews.apache.org/r/43799/diff/1/?file=1263508#file1263508line57> > > > > According to the style guide, we are usually using trailing underscores > > here.
We actually don't like that: > Some trailing underscores are used to distinguish between similar variables > in the same scope (think prime symbols), **but this should be avoided as much > as possible, including removing existing instances in the code base.** But it is true that prepending doesn't work either. > On Feb. 23, 2016, 3:06 p.m., Bernd Mathiske wrote: > > 3rdparty/libprocess/src/libevent_poll.cpp, line 58 > > <https://reviews.apache.org/r/43799/diff/1/?file=1263508#file1263508line58> > > > > Although this should work as is, it is more straight forward and the > > common (generally safer) pattern to access the shared pointer here, not the > > weak one. > > > > _ev.get() > > > > (respectively ev_.get(), see above) Thanks for cathing this, I had updated locally but never uploaded the corrected patch. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43799/#review120303 ----------------------------------------------------------- On Feb. 20, 2016, 2:09 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43799/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2016, 2:09 a.m.) > > > Review request for mesos, Joris Van Remoortere and Michael Park. > > > Bugs: MESOS-3271 and MESOS-4711 > https://issues.apache.org/jira/browse/MESOS-3271 > https://issues.apache.org/jira/browse/MESOS-4711 > > > Repository: mesos > > > Description > ------- > > Under certains circumstances, the future returned by poll is discarded right > after the event is triggered, this causes the event callback to be called > before the discard callback which results in an abort signal being raised > by the libevent library. > > > Diffs > ----- > > 3rdparty/libprocess/src/libevent_poll.cpp > 461624ca003e97be5ea9cf956d86fc294e6f1bc1 > > Diff: https://reviews.apache.org/r/43799/diff/ > > > Testing > ------- > > ```bash > # On CentOS 6.7 running in virtualbox > ../configure --enable-ssl --enable-libevent > make -j4 check > sudo ./bin/mesos-tests.sh > --gtest_filter="MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery" > --gtest_repeat=1000 > ``` > > > Thanks, > > Alexander Rojas > >
