-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43880/
-----------------------------------------------------------
(Updated Feb. 24, 2016, 9:46 a.m.)
Review request for mesos, Alexander Rukletsov and Ben Mahler.
Changes
-------
Addressed comments from Guangya Liu.
Bugs: MESOS-4720
https://issues.apache.org/jira/browse/MESOS-4720
Repository: mesos
Description
-------
Added allocator metrics for total and allocated scalar resources.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp
3043888630b066505410d3b32c5b3f813cc458c1
src/master/allocator/mesos/hierarchical.cpp
5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d
src/tests/hierarchical_allocator_tests.cpp
5f771f02db9bd098f3cd36730cd84bf2f5e87a33
Diff: https://reviews.apache.org/r/43880/diff/
Testing
-------
make check (OS X)
I confirmed that this does not lead to general performance regressions in the
allocator; this is partially expected since the added code only inserts metrics
in the allocator while the actual work is perform asynchronously. These tests
where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an
optimized build under OS X using clang(trunk) as compiler.
Thanks,
Benjamin Bannier
