----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43035/#review120619 -----------------------------------------------------------
Ship it! Ship It! - Joris Van Remoortere On Feb. 24, 2016, 11:41 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43035/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2016, 11:41 p.m.) > > > Review request for mesos and Joris Van Remoortere. > > > Repository: mesos > > > Description > ------- > > Check that even though we might fire a timer for a `GroupProcess` that has > been > destroyed, this does not result in dispatching an event to a reclaimed > process. > > > Diffs > ----- > > src/tests/group_tests.cpp af530f32fac47801a2cd0d941f3aa9196d448bd2 > > Diff: https://reviews.apache.org/r/43035/diff/ > > > Testing > ------- > > `make check; ./src/mesos-tests --gtest_filter="GroupTest.TimerCleanup" > --gtest_repeat=4000 --gtest_break_on_failure` > > I also verified that if you remove the `delete` of the `GroupProcess`, the > test fails because the `expired` callback is invoked (the `Clock::settle()` > is necessary to ensure that this happens). > > > Thanks, > > Neil Conway > >
