----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43779/#review120829 -----------------------------------------------------------
src/tests/reservation_endpoints_tests.cpp (line 1069) <https://reviews.apache.org/r/43779/#comment182352> I'd inline this into the lone use-site. src/tests/reservation_endpoints_tests.cpp (line 1228) <https://reviews.apache.org/r/43779/#comment182338> Mark this and the following string `const`. src/tests/reservation_endpoints_tests.cpp (line 1270) <https://reviews.apache.org/r/43779/#comment182347> I'd omit the variable and just call `createBasicAuthHeaders` in the args to `post()`. src/tests/reservation_endpoints_tests.cpp (line 1273) <https://reviews.apache.org/r/43779/#comment182351> The analogous test for volumes names these variables differently (`volume1`, `volume2`, and `volumes`). We should be consistent - Neil Conway On Feb. 26, 2016, 5:31 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43779/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2016, 5:31 a.m.) > > > Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway. > > > Bugs: MESOS-4591 > https://issues.apache.org/jira/browse/MESOS-4591 > > > Repository: mesos > > > Description > ------- > > Added '/reserve' tests with multiple roles. > > Operators may reserve resources for multiple roles in the same operation; > this patch adds tests to confirm correct behavior of authorization in this > case. The tests `ReservationEndpointsTest.GoodReserveACLMultipleRoles` and > `ReservationEndpointsTest.BadReserveACLMultipleRoles` were added. > > > Diffs > ----- > > src/tests/reservation_endpoints_tests.cpp > 32b2af4115211b58a5127a14dd19152c2eca120c > > Diff: https://reviews.apache.org/r/43779/diff/ > > > Testing > ------- > > Ran `configure && make check` and `configure --enable-libevent --enable-ssl > && make check` on OSX; all tests passed. > > > Thanks, > > Greg Mann > >
