----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41092/#review121005 -----------------------------------------------------------
src/slave/CMakeLists.txt (line 27) <https://reviews.apache.org/r/41092/#comment182584> I liked what you did with the master -- there should be only a `main.cpp` file here, so what do you think of just making this `add_executable(${AGENT_TARGET} main.cpp)`? src/slave/CMakeLists.txt (line 33) <https://reviews.apache.org/r/41092/#comment182587> Same comment as the master review -- I recommend putting the `*_TARGET`s inside a single variable inside `SlaveConfigure.cmake`, and simply calling `add_dependencies(${AGENT_TARGET} ${AGENT_DEPENDENCIES})` or whatever. This should be very similar to the slave. src/slave/CMakeLists.txt (line 37) <https://reviews.apache.org/r/41092/#comment182588> See comment above and comment in the master review for my recommendations here -- thinking it woudl be better to just put this into a single variable in `SlaveConfigure.cmake`. - Alex Clemmer On Feb. 13, 2016, 4:23 a.m., Diana Arroyo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41092/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2016, 4:23 a.m.) > > > Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van > Remoortere, and Joseph Wu. > > > Bugs: MESOS-3843 > https://issues.apache.org/jira/browse/MESOS-3843 > > > Repository: mesos > > > Description > ------- > > Added CMake file for agent executable build. > > > Diffs > ----- > > src/slave/CMakeLists.txt PRE-CREATION > src/slave/cmake/SlaveConfigure.cmake > fbdfdaa27fbd8c7429861eea5baf401a221f748b > > Diff: https://reviews.apache.org/r/41092/diff/ > > > Testing > ------- > > Tested on Ubuntu and OSX. > > > Thanks, > > Diana Arroyo > >
