----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/#review121434 -----------------------------------------------------------
src/tests/hierarchical_allocator_tests.cpp (lines 2449 - 2455) <https://reviews.apache.org/r/43881/#comment183131> no difference src/tests/hierarchical_allocator_tests.cpp (line 2463) <https://reviews.apache.org/r/43881/#comment183133> s/agent2/`agent2` s/framework1/`framework1` src/tests/hierarchical_allocator_tests.cpp (line 2464) <https://reviews.apache.org/r/43881/#comment183134> s/. Framework2 /, `framework2` src/tests/hierarchical_allocator_tests.cpp (line 2496) <https://reviews.apache.org/r/43881/#comment183135> s/agent2/`agent2` s/framework2/`framework2` src/tests/hierarchical_allocator_tests.cpp (line 2499) <https://reviews.apache.org/r/43881/#comment183129> two spaces - Guangya Liu On 二月 29, 2016, 7:59 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43881/ > ----------------------------------------------------------- > > (Updated 二月 29, 2016, 7:59 p.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Bugs: MESOS-4719 > https://issues.apache.org/jira/browse/MESOS-4719 > > > Repository: mesos > > > Description > ------- > > Added allocator metric for the number of allocations to a framework. > > > Diffs > ----- > > docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 > src/master/allocator/mesos/hierarchical.hpp > 3043888630b066505410d3b32c5b3f813cc458c1 > src/master/allocator/mesos/hierarchical.cpp > 24fa50f62dec10ed43089297473cc386d6ba2f78 > src/tests/hierarchical_allocator_tests.cpp > 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 > > Diff: https://reviews.apache.org/r/43881/diff/ > > > Testing > ------- > > make check (OS X) > > I confirmed that this does not lead to general performance regressions in the > allocator; this is partially expected since the added code only inserts > metrics in the allocator while the actual work is perform asynchronously. > These tests where performed with > `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build > under OS X using clang(trunk) as compiler. > > > Thanks, > > Benjamin Bannier > >
