----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44200/#review121445 -----------------------------------------------------------
src/slave/flags.hpp (lines 132 - 133) <https://reviews.apache.org/r/44200/#comment183149> Thinking about a proper naming. Consider remove `_dir`? src/slave/flags.cpp (lines 698 - 705) <https://reviews.apache.org/r/44200/#comment183150> While users can config the CNI network form a JSON file, is it possible to provide an option to define the CNI config from cli? - Gilbert Song On Feb. 29, 2016, 11:04 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44200/ > ----------------------------------------------------------- > > (Updated Feb. 29, 2016, 11:04 p.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4761 > https://issues.apache.org/jira/browse/MESOS-4761 > > > Repository: mesos > > > Description > ------- > > Add agent flags for specifying CNI plugin and config directories. > > > Diffs > ----- > > docs/configuration.md c4d094aac4acb95fd6648071413a3d5160dbf381 > docs/endpoints/slave/state.json.md a6403eea3426bdec81d170d0829ffe7174862e55 > docs/endpoints/slave/state.md bdd555e0231935c668dea1ba63582348db2b3629 > src/slave/flags.hpp c07932157ffe36ea36f1def4c7d92b79d2219c48 > src/slave/flags.cpp 7f139e99e8392fe95bb30070896ed9d95dfe5701 > src/slave/http.cpp 4eb1fafdfa72094511b0b2684a3c2705bd8c7c5e > > Diff: https://reviews.apache.org/r/44200/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
