> On March 1, 2016, 12:48 p.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2577 > > <https://reviews.apache.org/r/43882/diff/7/?file=1273644#file1273644line2577> > > > > Why don't you need to convert to `JSON::Number` first?
`time` is a `JSON::Number`; it was created from the `JSON::Value` `value` above. > On March 1, 2016, 12:48 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1216-1219 > > <https://reviews.apache.org/r/43882/diff/7/?file=1273643#file1273643line1216> > > > > As per our offline discussion, let's pull it out to libprocess. Maybe > > even create a ticket for a sweep change to use this new helper in relevant > > places? See https://reviews.apache.org/r/44261/. > On March 1, 2016, 12:48 p.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2568 > > <https://reviews.apache.org/r/43882/diff/7/?file=1273644#file1273644line2568> > > > > Here two event-based allocation happen, but you are only interested in > > one. Could you please describe your intention, so that folks understand why > > it is fine? Thanks. I added a comment. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/#review121406 ----------------------------------------------------------- On March 2, 2016, 11:34 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43882/ > ----------------------------------------------------------- > > (Updated March 2, 2016, 11:34 a.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Bugs: MESOS-4721 > https://issues.apache.org/jira/browse/MESOS-4721 > > > Repository: mesos > > > Description > ------- > > Added allocation metrics for allocation time. > > > Diffs > ----- > > docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 > src/master/allocator/mesos/hierarchical.cpp > 24fa50f62dec10ed43089297473cc386d6ba2f78 > src/master/allocator/mesos/metrics.hpp PRE-CREATION > src/tests/hierarchical_allocator_tests.cpp > 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 > > Diff: https://reviews.apache.org/r/43882/diff/ > > > Testing > ------- > > make check (OS X) > > I confirmed that this does not lead to general performance regressions in the > allocator; this is partially expected since the added code only inserts > metrics in the allocator while the actual work is perform asynchronously. > These tests where performed with > `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build > under OS X using clang(trunk) as compiler. > > > Thanks, > > Benjamin Bannier > >
