> On March 1, 2016, 1:19 a.m., Alexander Rojas wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 303 > > <https://reviews.apache.org/r/43884/diff/9/?file=1274396#file1274396line303> > > > > I'm even wondering whether `auto` here is a better idea than aliasing.
Of the two possible and discouraged approaches _type aliases_ and _auto_ I choose a type alias since we value verbosity. > On March 1, 2016, 1:19 a.m., Alexander Rojas wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1100-1109 > > <https://reviews.apache.org/r/43884/diff/9/?file=1274397#file1274397line1100> > > > > As in my previous comments, let's shy away from implicit calling a > > constructor. I this case I think creating the `Deferred` object outside > > even makes more sense. Fixed with specific and named getters like elsewhere. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review121366 ----------------------------------------------------------- On March 2, 2016, 11:34 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43884/ > ----------------------------------------------------------- > > (Updated March 2, 2016, 11:34 a.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Bugs: MESOS-4723 > https://issues.apache.org/jira/browse/MESOS-4723 > > > Repository: mesos > > > Description > ------- > > Added allocator metrics for used quotas. > > > Diffs > ----- > > docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 > src/master/allocator/mesos/hierarchical.hpp > 3043888630b066505410d3b32c5b3f813cc458c1 > src/master/allocator/mesos/hierarchical.cpp > 24fa50f62dec10ed43089297473cc386d6ba2f78 > src/master/allocator/mesos/metrics.hpp PRE-CREATION > src/tests/hierarchical_allocator_tests.cpp > 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 > > Diff: https://reviews.apache.org/r/43884/diff/ > > > Testing > ------- > > make check (OS X) > > I confirmed that this does not lead to general performance regressions in the > allocator; this is partially expected since the added code only inserts > metrics in the allocator while the actual work is perform asynchronously. > These tests where performed with > `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build > under OS X using clang(trunk) as compiler. > > > Thanks, > > Benjamin Bannier > >
