----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44221/#review121627 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/store.cpp (lines 72 - 78) <https://reviews.apache.org/r/44221/#comment183374> One question here, instead of exiting here, what about updating https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/containerizer.cpp#L116 by adding `docker/runtime` to `flags.isolation` dynamically when `docker` is included in `image_providers`? - Guangya Liu On 三月 1, 2016, 8:24 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44221/ > ----------------------------------------------------------- > > (Updated 三月 1, 2016, 8:24 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-4830 > https://issues.apache.org/jira/browse/MESOS-4830 > > > Repository: mesos > > > Description > ------- > > Added runtime isolator check if docker is image provider. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/store.cpp > 40bc00c7027d29d75a313edfe2c61a2756c546ae > > Diff: https://reviews.apache.org/r/44221/diff/ > > > Testing > ------- > > make check > > Tested with master and slave up. > > ./bin/mesos-slave.sh --master=127.0.0.1:5050 --work_dir=/tmp > --image_providers=DOCKER --launcher=linux --isolation=filesystem/linux > > > Thanks, > > Gilbert Song > >
