----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44070/#review121743 -----------------------------------------------------------
3rdparty/libprocess/src/metrics/metrics.cpp (lines 197 - 199) <https://reviews.apache.org/r/44070/#comment183547> This is definitely not enough to prevent a race here. Two `rateLimiters` may very well instantiated (though the once below will prevent the singleton from being initialized twice). Can we move the `Once initialize` test right after this if? - Alexander Rojas On March 2, 2016, 6:48 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44070/ > ----------------------------------------------------------- > > (Updated March 2, 2016, 6:48 p.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Bugs: MESOS-4776 > https://issues.apache.org/jira/browse/MESOS-4776 > > > Repository: mesos > > > Description > ------- > > Allowed disabling metrics endpoint rate limiting via the environment. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/metrics/metrics.hpp > 09b716be56eac38f75d79d917799c001aa0b205c > 3rdparty/libprocess/src/metrics/metrics.cpp > a9840083722dd6b7b6aab692ed449407ab125ac7 > > Diff: https://reviews.apache.org/r/44070/diff/ > > > Testing > ------- > > make check (OS X, not optimized) > > > Thanks, > > Benjamin Bannier > >
