----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44239/#review121758 -----------------------------------------------------------
Fix it, then Ship it! src/uri/fetchers/copy.cpp (line 85) <https://reviews.apache.org/r/44239/#comment183567> Why do you need this? src/uri/fetchers/copy.cpp (line 87) <https://reviews.apache.org/r/44239/#comment183569> Copying uri xxx to 'directory' src/uri/fetchers/copy.cpp (lines 132 - 137) <https://reviews.apache.org/r/44239/#comment183571> Why do you need this? - Jie Yu On March 2, 2016, 9:44 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44239/ > ----------------------------------------------------------- > > (Updated March 2, 2016, 9:44 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4834 > https://issues.apache.org/jira/browse/MESOS-4834 > > > Repository: mesos > > > Description > ------- > > This change adds support for fetching `file` URIs using the fetcher plugin > framework. > > > Diffs > ----- > > src/CMakeLists.txt 0832f1e9a850cc0d2c1112a446f0daf0190f8d7f > src/Makefile.am 5d8fe8bf33acb352589b2b3e0341987f9a41bc17 > src/tests/uri_fetcher_tests.cpp dcfba784d6ae49b8181b5a69dc00e82854ac4ff1 > src/uri/fetcher.hpp 5bc9703b76457413b5841710e0313f8bfa9047a1 > src/uri/fetcher.cpp 2d8d5b18b7a9b55be52288f17e85d6c406cfef88 > src/uri/fetchers/copy.hpp PRE-CREATION > src/uri/fetchers/copy.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44239/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >