-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44278/#review121756
-----------------------------------------------------------




src/master/http.cpp (line 440)
<https://reviews.apache.org/r/44278/#comment183566>

    s/stream/streamId/



src/master/http.cpp (lines 458 - 462)
<https://reviews.apache.org/r/44278/#comment183575>

    should these be BadRequest as well?



src/master/master.hpp (line 1605)
<https://reviews.apache.org/r/44278/#comment183578>

    s/_stream/_streamId/



src/master/master.hpp (line 1608)
<https://reviews.apache.org/r/44278/#comment183577>

    s/stream/streamId/



src/scheduler/scheduler.cpp (lines 501 - 502)
<https://reviews.apache.org/r/44278/#comment183580>

    pull this down to #516



src/scheduler/scheduler.cpp (line 678)
<https://reviews.apache.org/r/44278/#comment183579>

    s/stream/streamId/


- Vinod Kone


On March 2, 2016, 10:36 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44278/
> -----------------------------------------------------------
> 
> (Updated March 2, 2016, 10:36 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3583
>     https://issues.apache.org/jira/browse/MESOS-3583
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added HTTP scheduler stream IDs.
> 
> In some failure scenarios involving highly-available HTTP schedulers with 
> multiple instances, it's possible for a non-leading instance to successfully 
> make HTTP calls to the master. This patch enables the master to use HTTP 
> scheduler stream IDs to uniquely identify each HTTP subscription stream, 
> preventing any non-leading scheduler instance from making calls to the 
> master. The patch also adds stream ID support to the HTTP scheduler library.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 5e9e28e904ba0045ee27eb828f47231632a91d74 
>   src/master/master.hpp 13c6ff153e77c527822309e787942eb463d59e7d 
>   src/scheduler/scheduler.cpp 7ea1c2567f37a73160bca346a25bb2f0c54e71a0 
> 
> Diff: https://reviews.apache.org/r/44278/diff/
> 
> 
> Testing
> -------
> 
> `make check` was used to test on both OSX and CentOS 7.1.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Reply via email to