----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44342/#review121890 -----------------------------------------------------------
Hi, @jamespeach Your patch looks great. I have a question, `ENOSPC` only happen when call `write` and we could not register any singal handler in this isolator to receive a exceed quote singal, right? src/slave/containerizer/mesos/isolators/disk/xfs.cpp (line 364) <https://reviews.apache.org/r/44342/#comment183738> Need two space line between methods. src/slave/containerizer/mesos/isolators/disk/xfs.cpp (line 597) <https://reviews.apache.org/r/44342/#comment183739> Why we don't move assign logic to `isolate()`? - haosdent huang On March 3, 2016, 5 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44342/ > ----------------------------------------------------------- > > (Updated March 3, 2016, 5 p.m.) > > > Review request for mesos, Jie Yu and Jiang Yan Xu. > > > Bugs: MESOS-4828 > https://issues.apache.org/jira/browse/MESOS-4828 > > > Repository: mesos > > > Description > ------- > > Track sandbox directory usage by dynamically assigning XFS project > quotas. We track a range of XFS project IDs, assigning a project ID > and a project quota to each sandbox as it is created. When the task > reaches the quota, writes will fail with EDQUOT, and the task will have > an opportunity to handle that. > > Quotas are not applied to volume resources since the isolator interface > has no insight into the volume lifecycle. Thus it is not currently > possible to accurately assign and reclaim project IDs. > > If LOW is the lower bound of the project ID range and HIGH is the upper > bound, you can show the currently allocated project quotas using the > xfs_quota command: > > $ xfs_quota -x -c "report -a -n -L LOW -U HIGH" > > To show the project ID assigned to the file PATH, use the xfs_io command: > > $ xfs_io -r -c stat PATH > > > Diffs > ----- > > configure.ac b045d3c68a2d440bed4d1b3e6ab21a1bbe063517 > src/Makefile.am b30cc25f61856d6417437547baaa0bb338a30d63 > src/slave/containerizer/mesos/containerizer.cpp > af3ff5750649497d8852b4761c78d4cae5455a02 > src/slave/containerizer/mesos/isolators/disk/xfs.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/disk/xfs.cpp PRE-CREATION > src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 > src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 > > Diff: https://reviews.apache.org/r/44342/diff/ > > > Testing > ------- > > Manual testing on Fedora 23 w/ XFS. Make check on Fedora and OS X. > > > Thanks, > > James Peach > >
