----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/#review122047 -----------------------------------------------------------
Fix it, then Ship it! src/master/allocator/mesos/metrics.hpp (line 27) <https://reviews.apache.org/r/43880/#comment183888> Kill this line. src/master/allocator/mesos/metrics.cpp (lines 61 - 63) <https://reviews.apache.org/r/43880/#comment183930> Does it make sense to store the pointer to `HierarchicalAllocatorProcess` in the `Metrics` instance and remove the first parameter here? The value of this approach will be more evident when we will have more helpers later. src/tests/hierarchical_allocator_tests.cpp (line 2406) <https://reviews.apache.org/r/43880/#comment183890> s/users/frameworks src/tests/hierarchical_allocator_tests.cpp (lines 2420 - 2424) <https://reviews.apache.org/r/43880/#comment183893> Can you move it up where you check allocated/* metrics? Adding a framework shouldn't influence this counter. src/tests/hierarchical_allocator_tests.cpp (lines 2449 - 2453) <https://reviews.apache.org/r/43880/#comment183895> I think resources will be offered to `framework2`. But is it actually important? I think you can kill this comment altogether (also the similar one above), and add a short one around `settle()`. src/tests/hierarchical_allocator_tests.cpp (line 2463) <https://reviews.apache.org/r/43880/#comment183894> Feel free to kill this line. src/tests/hierarchical_allocator_tests.cpp (line 2491) <https://reviews.apache.org/r/43880/#comment183896> /cluster/cluster state/ - Alexander Rukletsov On March 3, 2016, 4:17 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43880/ > ----------------------------------------------------------- > > (Updated March 3, 2016, 4:17 p.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Bugs: MESOS-4720 > https://issues.apache.org/jira/browse/MESOS-4720 > > > Repository: mesos > > > Description > ------- > > Added allocator metrics for total and allocated scalar resources. > > > Diffs > ----- > > docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 > src/master/allocator/mesos/hierarchical.hpp > 3043888630b066505410d3b32c5b3f813cc458c1 > src/master/allocator/mesos/hierarchical.cpp > 70291075c00a9a557529c2562dedcfc6c6c3ec32 > src/master/allocator/mesos/metrics.hpp PRE-CREATION > src/master/allocator/mesos/metrics.cpp PRE-CREATION > src/tests/hierarchical_allocator_tests.cpp > 3e4ad31925e1b815a74d67fa3962d23fa5bc89d1 > > Diff: https://reviews.apache.org/r/43880/diff/ > > > Testing > ------- > > make check (OS X) > > I confirmed that this does not lead to general performance regressions in the > allocator; this is partially expected since the added code only inserts > metrics in the allocator while the actual work is perform asynchronously. > These tests where performed with > `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build > under OS X using clang(trunk) as compiler. > > > Thanks, > > Benjamin Bannier > >