> On Feb. 29, 2016, 10:24 a.m., Vinod Kone wrote: > > Thanks for working on this Qian! > > > > It's really hard to tell what changes were made to the http command > > executor that are different from the command executor. I would suggest you > > to split this into multiple reviews to make reviewers' life easy. > > > > 1) Add http command executor to make files. Just copy executor.cpp to > > http_command_executor.cpp without any changes. > > 2) Update http_command_executor.cpp to use v1 API. > > 3) Make changes to flags.cpp and slave.cpp. > > 4) Update/parameterize tests (slave recovery tests?) to use http command > > executor. > > Qian Zhang wrote: > Sure Vinod, I will discard this patch, and upload multiple sub-patches > accordingly. > > Vinod Kone wrote: > Hey any updates on this?
Sorry for the late, I have uploaded patches for 1), 2) and 3), and I am working on 4), can you please help review the first 3 patches? Thanks. https://reviews.apache.org/r/44423/ - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43701/#review121177 ----------------------------------------------------------- On Feb. 20, 2016, 9:44 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43701/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2016, 9:44 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-3558 > https://issues.apache.org/jira/browse/MESOS-3558 > > > Repository: mesos > > > Description > ------- > > Added a command executor based on the new V1 API. > > > Diffs > ----- > > docs/configuration.md b04e873009dc783cc50eb02a459f0587d020ad23 > include/mesos/v1/mesos.proto e4224afe2245d649afa1a6c97bae26c215e6fada > src/Makefile.am 27aec37524aa33211e0ca4594e127ebb4279e9b0 > src/launcher/http_executor.cpp PRE-CREATION > src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61 > src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a > src/slave/slave.cpp f0be0d5bf4b853952caf06e2e262c2903d79ead3 > > Diff: https://reviews.apache.org/r/43701/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
