----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44441/#review122305 -----------------------------------------------------------
Hi Guangya, Thanks for taking this on. My main consideration about this patch is making distinction between shell command v.s. non-shell command. We have two choices: 1. Following your current implementation, the description of the `command` flag should be updated, because people may not know they should use `--command=value,argv1,argv1` as non-shell command. 2. Or we should make user specifying `value` and `argv` explicitly, by making them as flags. We should find out which is better. - Gilbert Song On March 7, 2016, 12:05 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44441/ > ----------------------------------------------------------- > > (Updated March 7, 2016, 12:05 a.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-4882 > https://issues.apache.org/jira/browse/MESOS-4882 > > > Repository: mesos > > > Description > ------- > > Treated command as executable value and arguments in mesos-execute. > > > Diffs > ----- > > src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e > > Diff: https://reviews.apache.org/r/44441/diff/ > > > Testing > ------- > > ./src/mesos-execute --master=192.168.56.12:5050 --name=test_mesos > --docker_image=busybox:latest --containerizer=mesos --no-shell > --command="ls,/etc/passwd" > I0307 15:48:09.834506 27450 sched.cpp:222] Version: 0.29.0 > I0307 15:48:09.841404 27468 sched.cpp:326] New master detected at > master@192.168.56.12:5050 > I0307 15:48:09.843992 27468 sched.cpp:336] No credentials provided. > Attempting to register without authentication > I0307 15:48:09.848901 27468 sched.cpp:703] Framework registered with > a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001 > Framework registered with a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001 > task test_mesos submitted to slave 6fa2afa1-768b-4f2e-9c69-9f1017634e72-S2 > Received status update TASK_RUNNING for task test_mesos > Received status update TASK_FINISHED for task test_mesos > I0307 15:48:10.284418 27466 sched.cpp:1903] Asked to stop the driver > I0307 15:48:10.284494 27466 sched.cpp:1143] Stopping framework > 'a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001' > > > Thanks, > > Guangya Liu > >
