----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44454/#review122446 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/network/port_mapping.hpp (lines 66 - 72) <https://reviews.apache.org/r/44454/#comment184449> This is not the reliable solution. What if /var/run points to some other place? I think we should make this a field member (instead of a constant), and call realpath when creating the isolator. - Jie Yu On March 7, 2016, 3:42 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44454/ > ----------------------------------------------------------- > > (Updated March 7, 2016, 3:42 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4662 > https://issues.apache.org/jira/browse/MESOS-4662 > > > Repository: mesos > > > Description > ------- > > Returned real path for PORT_MAPPING_BIND_MOUNT_ROOT. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/port_mapping.hpp > 0fe2f486eb733acf738c1c61fc44f820d7401afc > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp > 134b6c759b769cf335539e49eff817973c7f96a4 > > Diff: https://reviews.apache.org/r/44454/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
