----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44363/#review122600 -----------------------------------------------------------
Fix it, then Ship it! Looks good thanks, can you ask Jie about the naming scheme for the flag value? src/Makefile.am (lines 907 - 911) <https://reviews.apache.org/r/44363/#comment184708> I was going to ask that we update cmake with these additional files, but it seems cmake doesn't include the handling of the network isolation stuff yet, so let's punt for now. src/slave/containerizer/mesos/containerizer.cpp (lines 220 - 222) <https://reviews.apache.org/r/44363/#comment184712> Can we get some feedback from Jie about the naming we've chosen here? src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.hpp (line 19) <https://reviews.apache.org/r/44363/#comment184713> Only one newline here src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.cpp (line 55) <https://reviews.apache.org/r/44363/#comment184714> No periods at the end of error / failure messages, can you do a sweep here? - Ben Mahler On March 4, 2016, 1:10 a.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44363/ > ----------------------------------------------------------- > > (Updated March 4, 2016, 1:10 a.m.) > > > Review request for mesos, Ben Mahler and Rob Todd. > > > Bugs: MESOS-4623 > https://issues.apache.org/jira/browse/MESOS-4623 > > > Repository: mesos > > > Description > ------- > > This is the first isolator to fall under the category of cgroup > devices. However, we do not yet have a generic cgroup device isolator > (nor will we in the very near future). As such, I have preemptively > created the nvidia gpu isolator in the directory hierarchy under the > path: > > src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/ > > in order to easily allow them to fall under the category of gpu > devices later on. > > In this stub implementation, initialization of the agent will > fail if the nvidia gpu isolator is enabled via the agent --isolation > flag. That is --isolation="cgroups/devices/gpu/nvidia". In a > subsequent commit we will fill in the guts to actually enable the > proper isolation. > > The flags documentation has been udpated accordingly. > > > Diffs > ----- > > docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c > src/Makefile.am 5b54fe04734afc5faa1bba3b84f43a1b8efe8753 > src/slave/containerizer/mesos/containerizer.cpp > af3ff5750649497d8852b4761c78d4cae5455a02 > src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.hpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.cpp > PRE-CREATION > src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 > > Diff: https://reviews.apache.org/r/44363/diff/ > > > Testing > ------- > > > Thanks, > > Kevin Klues > >
