----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43920/#review122613 -----------------------------------------------------------
Looks good. Before I give a "Ship It!", your next steps should be: - Add a unit test. - Modify the following classes in src/tests/environment.cpp: - CurlFilter - LogrotateFilter - NetcatFilter - PerfCPUCyclesFilter - PerfFilter - Modify PortMappingIsolatorTest::SetUpTestCase in src/tests/containerizer/port_mapping_tests.cpp - Modify the `sha512` command in src/common/command_utils.cpp - Modify the `logrotate_path` flag validation logic in src/slave/container_loggers/lib_logrotate.hpp and logrotate.hpp 3rdparty/libprocess/3rdparty/stout/include/stout/os/which.hpp (line 25) <https://reviews.apache.org/r/43920/#comment184720> Nit: s/os{/os {/ 3rdparty/libprocess/3rdparty/stout/include/stout/os/which.hpp (lines 27 - 28) <https://reviews.apache.org/r/43920/#comment184721> Suggestion: Searches for an executable `command` on the environment variable `PATH`. If found, returns the absolute path to the command. Otherwise, returns `None`. 3rdparty/libprocess/3rdparty/stout/include/stout/os/which.hpp (line 51) <https://reviews.apache.org/r/43920/#comment184723> Nit: no indent here. 3rdparty/libprocess/3rdparty/stout/include/stout/os/which.hpp (line 52) <https://reviews.apache.org/r/43920/#comment184724> Nit: add one newline preceding this line. - Joseph Wu On March 8, 2016, 6:22 a.m., Disha Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43920/ > ----------------------------------------------------------- > > (Updated March 8, 2016, 6:22 a.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-4576 > https://issues.apache.org/jira/browse/MESOS-4576 > > > Repository: mesos > > > Description > ------- > > Added a helper function to stout : os/which.hpp. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/which.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/43920/diff/ > > > Testing > ------- > > > Thanks, > > Disha Singh > >
