----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44531/#review122657 -----------------------------------------------------------
src/docker/docker.cpp (lines 306 - 307) <https://reviews.apache.org/r/44531/#comment184770> I found that the NetworkMode is `default` when using `bridge` mode, so the value of `networkModeValue` would be `default` but not `bridge`, and this will cause line 315 constrcut a invalid addressLocation as `NetworkSettings.Networks.default.IPAddress` which will always failed and thus fall to old API. - Guangya Liu On 三月 8, 2016, 10:54 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44531/ > ----------------------------------------------------------- > > (Updated 三月 8, 2016, 10:54 p.m.) > > > Review request for mesos, Dan Osborne, Jie Yu, and Travis Hegner. > > > Bugs: MESOS-4370 > https://issues.apache.org/jira/browse/MESOS-4370 > > > Repository: mesos > > > Description > ------- > > Fixed parsing network ip address with docker. > > > Diffs > ----- > > src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 > > Diff: https://reviews.apache.org/r/44531/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
