----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/#review122668 -----------------------------------------------------------
Fix it, then Ship it! src/slave/constants.cpp (line 58) <https://reviews.apache.org/r/44515/#comment184781> Can you create a JIRA issue so we make the naming of the realm symetric in the master to _mesos-master_. I think only the master's `DEFAULT_HTTP_AUTHENTICATION_REALM` should be changed. - Alexander Rojas On March 8, 2016, 7:59 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44515/ > ----------------------------------------------------------- > > (Updated March 8, 2016, 7:59 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, and Till Toenshoff. > > > Bugs: MESOS-4849 > https://issues.apache.org/jira/browse/MESOS-4849 > > > Repository: mesos > > > Description > ------- > > Added agent flags for HTTP authentication. > > Three command-line flags have been added to the agent to enable HTTP > authentication: `--authenticate_http`, `--http_credentials`, and > `--http_authenticators`. > > > Diffs > ----- > > src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 > src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2 > src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 > src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 > src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 > src/tests/mesos.cpp e0f641c6828833de13a0a233e39ff6dc3f343d5c > > Diff: https://reviews.apache.org/r/44515/diff/ > > > Testing > ------- > > `make check` was used to test. However, these flags aren't yet incorporated > into any agent endpoints. We should probably wait to merge this patch along > with the changes for https://issues.apache.org/jira/browse/MESOS-4850 when > they're ready. > > > Thanks, > > Greg Mann > >
