----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44511/#review122722 -----------------------------------------------------------
Patch looks great! Reviews applied: [41681, 43863, 44512, 41790, 44511] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On March 9, 2016, 10:03 a.m., Yongqiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44511/ > ----------------------------------------------------------- > > (Updated March 9, 2016, 10:03 a.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-4797 > https://issues.apache.org/jira/browse/MESOS-4797 > > > Repository: mesos > > > Description > ------- > > Add registry tests for /weights endpoint. > > > Diffs > ----- > > src/tests/dynamic_weights_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44511/diff/ > > > Testing > ------- > > Add three sub tests for /weights endpoint registry in this patch: > > 1. Tests whether the weights replicated log is initialized with the > `--weights` flag when bootstrapping the cluster. > 2. Tests whether the weights replicated log can be updated with `/weights` > endpoint. > 3. Tests whether the `--weights` flag is ignored and use the registry value > instead when Mesos master subsequently starts with `--weights` flag still > specified. > > > make && make check. > > > Thanks, > > Yongqiao Wang > >