----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/#review122725 -----------------------------------------------------------
include/mesos/mesos.proto (line 442) <https://reviews.apache.org/r/44570/#comment184821> what if it's specified in both places, two different ways? I think there's room for a little more description in these comments. src/master/validation.cpp (line 379) <https://reviews.apache.org/r/44570/#comment184822> this is exactly the type of thing that I'd expect to be documented in the protobuf - James DeFelice On March 9, 2016, 3 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44570/ > ----------------------------------------------------------- > > (Updated March 9, 2016, 3 p.m.) > > > Review request for mesos, Adam B and Joerg Schad. > > > Bugs: MESOS-4772 > https://issues.apache.org/jira/browse/MESOS-4772 > > > Repository: mesos > > > Description > ------- > > To be able to authenticate HTTP requests for tasks, the authorizer has to > determine who owns the tasks. This is achieved by adding an owner field to > TaskInfo and ExecutorInfo. > > > Diffs > ----- > > include/mesos/mesos.proto 3d22ec32655dca741169e1f0e382303e061c38b7 > src/master/validation.hpp 29dbdf1da540db4966ff9e86037badde06e69a4b > src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca > src/tests/master_validation_tests.cpp > c9bc38ce604d2d44d6e6b1286507d1c45e5e9e25 > > Diff: https://reviews.apache.org/r/44570/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
