----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44379/ -----------------------------------------------------------
(Updated 三月 10, 2016, 3:24 a.m.) Review request for mesos. Changes ------- Rephrase the commit log and comments to make it clear Summary (updated) ----------------- Correctly parse perf stat format for non-vanilla 3.10 kernel. Bugs: MESOS-4705 https://issues.apache.org/jira/browse/MESOS-4705 Repository: mesos Description (updated) ------- For vanilla kernel <= 3.12, 'perf stat' format is: value,event,cgroup Tested with 3.12, 3.11, 3.10 vanilla kernel. OS vendors may enhance perf tools with additional format: value,unit,event,cgroup,running,ratio Tested on Centos 7 with kernel 3.10.0-{123 OR 229}.el7.x86_64 Diffs (updated) ----- src/linux/perf.cpp 1c113a2b3f57877e132bbd65e01fb2f045132128 Diff: https://reviews.apache.org/r/44379/diff/ Testing (updated) ------- 1. {Found and Test} with Serenity, ema filter could get perf event statistics correctly as expected. 2. ./bin/mesos-tests.sh --gtest_filter=PerfEventIsolatorTest* --log_dir=/tmp/mesos/ Thanks, fan du