> On March 10, 2016, 6:26 a.m., Adam B wrote: > > src/tests/master_maintenance_tests.cpp, line 129 > > <https://reviews.apache.org/r/44186/diff/5/?file=1280007#file1280007line129> > > > > Why set this to false and then still createBasicAuthHeaders for these > > tests? > > Why can't we keep this at `true`?
Done. - Joerg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44186/#review122886 ----------------------------------------------------------- On March 10, 2016, 10:31 a.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44186/ > ----------------------------------------------------------- > > (Updated March 10, 2016, 10:31 a.m.) > > > Review request for mesos, Adam B, Alexander Rojas, and Greg Mann. > > > Bugs: MESOS-4844 > https://issues.apache.org/jira/browse/MESOS-4844 > > > Repository: mesos > > > Description > ------- > > Added Authentication to master http endpoints (except version, health, > redirect, scheduler). > > > Diffs > ----- > > src/master/http.cpp 7304bfd5350d763d9ed1d5acdc285874b6d8f5df > src/master/master.hpp 4fa88f1968c92c1216c0af22a476ef7aa57ae961 > src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc > src/tests/fault_tolerance_tests.cpp > d193897e636efd0e3ef67bf67fcd6255a3de0341 > src/tests/health_check_tests.cpp d0fd27fd8a6b48511ef8cafab5dff59f65729d9f > src/tests/master_maintenance_tests.cpp > 3faa8136cf57276295553910319480028f433e4c > src/tests/master_tests.cpp 2f4d820e223a48700ce1ac3a91b7256cc836c268 > src/tests/persistent_volume_endpoints_tests.cpp > 81185a161498394020a27f1f5bf747bac5425f43 > src/tests/repair_tests.cpp bb104562659e135492f9857e5b452c8a0a9e97da > src/tests/role_tests.cpp fc3a72894631279460ee7971a4627d73c3d8c351 > src/tests/status_update_manager_tests.cpp > d64d3b8c96270478f6b681c038de77c3a9eb68fe > > Diff: https://reviews.apache.org/r/44186/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joerg Schad > >
