----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44652/#review122944 -----------------------------------------------------------
Fix it, then Ship it! src/launcher/executor.cpp (line 124) <https://reviews.apache.org/r/44652/#comment185048> Not sure whether we have a real style for that, but the example I seen (and used myself) are to comment the name. See https://github.com/apache/mesos/blob/master/3rdparty/libprocess/src/openssl.cpp#L155 for an example. In this case I don't believe it makes a large difference as the Type is descriptive enough, but that might be different with more general types (imagine a string). - Joerg Schad On March 10, 2016, 5:14 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44652/ > ----------------------------------------------------------- > > (Updated March 10, 2016, 5:14 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e > > Diff: https://reviews.apache.org/r/44652/diff/ > > > Testing > ------- > > The complete chain was tested. See https://reviews.apache.org/r/44662/. > > > Thanks, > > Alexander Rukletsov > >