> On March 11, 2016, 3:10 p.m., Joerg Schad wrote: > > docs/authentication.md, line 12 > > <https://reviews.apache.org/r/44554/diff/2/?file=1293660#file1293660line12> > > > > s/certain/most (I can also change that while adding authn to master > > endpoints).
I'll let you make this change if you want in your patch, since I'm only adding authN to two endpoints (three if you count `/state.json`) here; I think the more important change is to add more documentation on which endpoints have authentication enabled, which you just brought up as well! Good idea :-) > On March 11, 2016, 3:10 p.m., Joerg Schad wrote: > > docs/configuration.md, line 1005 > > <https://reviews.apache.org/r/44554/diff/2/?file=1293661#file1293661line1005> > > > > We should add a clarification what this credential is used for (because > > otherwise we have have twice the same text): "This credential is used to > > identify the slave to the master." Good call; I added these changes to the docs here in this patch, and the corresponding changes to the flags source code in https://reviews.apache.org/r/44515/ - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44554/#review123146 ----------------------------------------------------------- On March 11, 2016, 3:52 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44554/ > ----------------------------------------------------------- > > (Updated March 11, 2016, 3:52 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till > Toenshoff. > > > Bugs: MESOS-4850 > https://issues.apache.org/jira/browse/MESOS-4850 > > > Repository: mesos > > > Description > ------- > > Added agent HTTP authentication to the docs. > > > Diffs > ----- > > docs/authentication.md dd538b512c6f822cd742fc6e2f3d4f7fbffadc06 > docs/configuration.md f6e84023b90e560594429826ed7163310d62b265 > docs/home.md fd7794f56b4a95268dbb82288d99cab19a89f5cd > > Diff: https://reviews.apache.org/r/44554/diff/ > > > Testing > ------- > > Viewed with the Mesos website container: > https://github.com/mesosphere/mesos-website-container > > > Thanks, > > Greg Mann > >
