----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44456/#review123246 -----------------------------------------------------------
Fix it, then Ship it! src/tests/containerizer/provisioner_appc_tests.cpp (lines 805 - 808) <https://reviews.apache.org/r/44456/#comment185454> Should we do that in LinuxRootfs? src/tests/containerizer/provisioner_appc_tests.cpp (line 849) <https://reviews.apache.org/r/44456/#comment185455> path::join(mntDir, ""); src/tests/containerizer/provisioner_appc_tests.cpp (lines 878 - 898) <https://reviews.apache.org/r/44456/#comment185456> This pattern occurs several times. Can we introduce a helper in this file? - Jie Yu On March 11, 2016, 5:06 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44456/ > ----------------------------------------------------------- > > (Updated March 11, 2016, 5:06 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4818 > https://issues.apache.org/jira/browse/MESOS-4818 > > > Repository: mesos > > > Description > ------- > > Added Appc provisioner integration test. > > > Diffs > ----- > > src/tests/containerizer/provisioner_appc_tests.cpp > 6c8087e17aa8b7139ba12337d5be472b7099e77f > > Diff: https://reviews.apache.org/r/44456/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
