> On March 12, 2016, 2:28 a.m., Ben Mahler wrote: > > src/slave/constants.hpp, lines 116-118 > > <https://reviews.apache.org/r/44719/diff/1/?file=1296120#file1296120line116> > > > > Can this be in-line or is there a circular dependency issue that > > warrants the .cpp file?
This can be in the header file, but it would require having the slave's `constants.hpp` include the master's `constants.hpp`, which seemed like something we'd want to avoid. Happy to make this change if you think it isn't a problem though. - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44719/#review123258 ----------------------------------------------------------- On March 11, 2016, 6:32 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44719/ > ----------------------------------------------------------- > > (Updated March 11, 2016, 6:32 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > Avoided external linkage for slave constants. > > > Diffs > ----- > > src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 > src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2 > > Diff: https://reviews.apache.org/r/44719/diff/ > > > Testing > ------- > > > Thanks, > > Neil Conway > >
