> On March 13, 2016, 8:26 a.m., Adam B wrote: > > src/tests/master_maintenance_tests.cpp, line 1786 > > <https://reviews.apache.org/r/44621/diff/4/?file=1296325#file1296325line1786> > > > > You can't use `badAuthnHeaders` here, because of the content-type?
Yes. > On March 13, 2016, 8:26 a.m., Adam B wrote: > > src/tests/master_tests.cpp, line 4265 > > <https://reviews.apache.org/r/44621/diff/4/?file=1296326#file1296326line4265> > > > > There is no GET request allowed on /weights (yet), so it's interesting > > to me that this part of the test passes. I would expect it to return 405 > > MethodNotAllowed. Or I guess authentication happens before we even get to > > the handler to check the action? I removed the test for now (especially as there is no http::put yet). Will add that with a follow up patch. - Joerg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44621/#review123302 ----------------------------------------------------------- On March 11, 2016, 7:49 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44621/ > ----------------------------------------------------------- > > (Updated March 11, 2016, 7:49 p.m.) > > > Review request for mesos, Adam B and Alexander Rojas. > > > Bugs: MESOS-4844 > https://issues.apache.org/jira/browse/MESOS-4844 > > > Repository: mesos > > > Description > ------- > > With enabling http authentication for http endpoints we should also add tests > to check > that http request to those endpoints return "401 Unauthorized" if queried > without or with > bad credentials. > > > Diffs > ----- > > src/tests/master_maintenance_tests.cpp > 3c7024cfbd7e5bef75f092eace8d0e80000ca423 > src/tests/master_tests.cpp 2f4d820e223a48700ce1ac3a91b7256cc836c268 > src/tests/repair_tests.cpp bb104562659e135492f9857e5b452c8a0a9e97da > src/tests/role_tests.cpp fc3a72894631279460ee7971a4627d73c3d8c351 > > Diff: https://reviews.apache.org/r/44621/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joerg Schad > >