----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44790/ -----------------------------------------------------------
Review request for mesos and Joris Van Remoortere. Repository: mesos Description ------- Previously the Error behavior (in particular where the child process is killed) was not consistent among Error cases. We should establish the convention that the Hook itself returns an error, while the subprocess code is resposible for killing the child process in case of such Error. Diffs ----- src/linux/systemd.hpp 6b240b9cc2fe559d111a4235e70f00e07f3d4495 src/linux/systemd.cpp e120d2ceffe6bb400859f2a132f02a99f561f856 Diff: https://reviews.apache.org/r/44790/diff/ Testing ------- sudo make check (on Linux) Thanks, Joerg Schad