> On March 15, 2016, 10:33 a.m., Joerg Schad wrote: > > src/slave/flags.cpp, line 682 > > <https://reviews.apache.org/r/44515/diff/8/?file=1296989#file1296989line682> > > > > As we are actively deprecated the old text based format with Mesos-228, > > does it make sense to only document the new json format here? > > Joerg Schad wrote: > Mesos-2281 > > Greg Mann wrote: > Perhaps we should see which patch lands first, and update the other one > accordingly? I can put a comment on Jan's review so that he's aware of this > one.
After looking at Jan's patch again I see that it's just beginning the deprecation cycle for that change; I think it makes sense to introduce the `--http_credentials` flag using only the JSON format, regardless of which patch lands first. I altered this patch chain accordingly. Thanks Joerg! - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/#review123630 ----------------------------------------------------------- On March 15, 2016, 9:30 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44515/ > ----------------------------------------------------------- > > (Updated March 15, 2016, 9:30 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till > Toenshoff. > > > Bugs: MESOS-4849 > https://issues.apache.org/jira/browse/MESOS-4849 > > > Repository: mesos > > > Description > ------- > > Added agent flags for HTTP authentication. > > Three command-line flags have been added to the agent to enable HTTP > authentication: `--authenticate_http`, `--http_credentials`, and > `--http_authenticators`. > > > Diffs > ----- > > src/slave/constants.hpp 0b4e41b4eee3280515cf8a1f049fe923503066f1 > src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 > src/slave/flags.cpp 4d10818105627738e258116647ccada374e3d7b9 > src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 > src/tests/mesos.cpp 7cca4ed4753fa365b209d1d22f0df4650b19bc6a > > Diff: https://reviews.apache.org/r/44515/diff/ > > > Testing > ------- > > `sudo make check` was used to test on both OSX and Ubuntu 14.04. > > > Thanks, > > Greg Mann > >