----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44874/#review123803 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp (line 19) <https://reviews.apache.org/r/44874/#comment186071> Probably should remove this newline. Similarly for newline between `path.hpp` and `os.hpp` includes (not yours, I realize). 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp (line 222) <https://reviews.apache.org/r/44874/#comment186068> Why is this a `string&` and `newDirectory` is a `string`? I'd think both should probably be `string`. - Neil Conway On March 15, 2016, 11:47 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44874/ > ----------------------------------------------------------- > > (Updated March 15, 2016, 11:47 p.m.) > > > Review request for mesos, Jie Yu and Neil Conway. > > > Repository: mesos > > > Description > ------- > > Added support for FTS_SLNONE in rmdir. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp > cf21e7fe458626c7533e596997cab3afdabb55f4 > 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp > 291a22b5aae53b0bc32ae18b9343ceb5a638b37b > > Diff: https://reviews.apache.org/r/44874/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
