----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41334/#review123824 -----------------------------------------------------------
include/mesos/resources.hpp (line 170) <https://reviews.apache.org/r/41334/#comment186113> I think we should also update those helper fuction according to protobuf change, using `throttleable` instead of ALLOCATION_SLACK/USAGE_SLACK, e.g. `throttleable()`, `nonThrottleable()` and `revocable()`. - Klaus Ma On March 15, 2016, 10:33 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41334/ > ----------------------------------------------------------- > > (Updated March 15, 2016, 10:33 p.m.) > > > Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van > Remoortere, Joseph Wu, and Klaus Ma. > > > Bugs: MESOS-4146 > https://issues.apache.org/jira/browse/MESOS-4146 > > > Repository: mesos > > > Description > ------- > > This helper function is used to filter out allocation slack resources. > > > Diffs > ----- > > include/mesos/resources.hpp bb343ad852576a75615a93ef850b413bf77698e0 > include/mesos/v1/resources.hpp 719110fbbf39f1755460ac0b32e3893656054a4e > src/common/resources.cpp 1f23dc83f7330c305a836d698f114b7eaf3d7ba1 > src/tests/resources_tests.cpp 6b004d64bb25112b19fc5d98b5bca874c5329e8c > src/v1/resources.cpp c6f125ec317e2da537a6456f5cff2da0a48701d8 > > Diff: https://reviews.apache.org/r/41334/diff/ > > > Testing > ------- > > make > make check > GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="RevocableResourceTest.Filter" > --verbose > > > Thanks, > > Guangya Liu > >
