----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44669/#review124282 -----------------------------------------------------------
src/master/detectors/detector.cpp (line 126) <https://reviews.apache.org/r/44669/#comment186752> Extraneous space here. src/master/detectors/detector.cpp (line 128) <https://reviews.apache.org/r/44669/#comment186754> Hmmm... on closer inspection, this might not work. This constructor for the `StandaloneMasterDetector` needs to be manually `->appoint()`d later. It will be better to return an `Error` here instead. - Joseph Wu On March 17, 2016, 5:29 p.m., Anurag Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44669/ > ----------------------------------------------------------- > > (Updated March 17, 2016, 5:29 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-4610 > https://issues.apache.org/jira/browse/MESOS-4610 > > > Repository: mesos > > > Description > ------- > > The createFromModule will be used to create a MasterContender/Detector > from a module (specified using the --modules flag on the command > line). > > > Diffs > ----- > > src/master/contenders/contender.cpp PRE-CREATION > src/master/detectors/detector.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44669/diff/ > > > Testing > ------- > > See https://reviews.apache.org/r/44670/. > > > Thanks, > > Anurag Singh > >
