> On March 17, 2016, 2:16 a.m., Guangya Liu wrote: > > src/cli/execute.cpp, lines 251-281 > > <https://reviews.apache.org/r/44934/diff/1/?file=1301837#file1301837line251> > > > > What is the behavior of this if with mesos containerizer but without a > > docker/appc image? > > > > The current logic is a bit different from previous logic, the mesos > > execute will not construct the containerInfo if no docker image.
Thanks for the review ! Updated the patch. - Jojy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44934/#review123969 ----------------------------------------------------------- On March 16, 2016, 9:21 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44934/ > ----------------------------------------------------------- > > (Updated March 16, 2016, 9:21 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Updated mesos-execute to add support for Appc. > > > Diffs > ----- > > src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e > > Diff: https://reviews.apache.org/r/44934/diff/ > > > Testing > ------- > > Tested with various Appc images. > > > Thanks, > > Jojy Varghese > >
