----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44851/#review124053 -----------------------------------------------------------
src/master/allocator/mesos/metrics.hpp (lines 40 - 41) <https://reviews.apache.org/r/44851/#comment186400> Can you clarify here what the deprecation cycle is? It would be helpful to say that the new one was added in 0.29.0. Could you also update the CHANGELOG with this deprecation and point users towards using the new metric name? - Ben Mahler On March 15, 2016, 2:51 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44851/ > ----------------------------------------------------------- > > (Updated March 15, 2016, 2:51 p.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > Since allocators can be replaced with a custom module instead use a > name clearly communicating that the metrics reported here are related > to the default (hierarchical) allocator. > > For backwards compatibility we continue to support the old metrics > name. > > > Diffs > ----- > > src/master/allocator/mesos/metrics.hpp > d04e9a11c77b6fb2d522608e3085f81f8a6657ca > src/master/allocator/mesos/metrics.cpp > 46dd7f7b3d8d49c59b42e789fe5dcd49f1693ace > > Diff: https://reviews.apache.org/r/44851/diff/ > > > Testing > ------- > > check make check (OS X, clang-trunk) here and with later patches using other > allocator metrics. > > > Thanks, > > Benjamin Bannier > >
