----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44975/#review124375 -----------------------------------------------------------
I ran the review by Ben again and sat with him to rework it to his satisfaction. The commit can be found on this branch: https://github.com/klueska-mesosphere/mesos/commits/r/a10gupta/cgroups-devices If you just apply the patch as is, Ben says he will get it committed early next week. - Kevin Klues On March 18, 2016, 9:35 a.m., Abhishek Dasgupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44975/ > ----------------------------------------------------------- > > (Updated March 18, 2016, 9:35 a.m.) > > > Review request for mesos, Ben Mahler, Felix Abecassis, Kevin Klues, and > Niklas Nielsen. > > > Bugs: MESOS-3368 > https://issues.apache.org/jira/browse/MESOS-3368 > > > Repository: mesos > > > Description > ------- > > Updated cgroups test cases to include two test cases > CgroupsAnyHierarchyDevicesTest.ParseTest and > CgroupsAnyHierarchyDevicesTest.ROOT_CGROUPS_Devices in order to test device > support in cgroup. > > > Diffs > ----- > > src/tests/containerizer/cgroups_tests.cpp > acaed9b3f8a04964092cef413133834d0cf5a145 > > Diff: https://reviews.apache.org/r/44975/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Abhishek Dasgupta > >
