----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45057/#review124380 -----------------------------------------------------------
src/launcher/fetcher.cpp (line 77) <https://reviews.apache.org/r/45057/#comment186903> This would ignore the error when the zip file is broken. Is it possible to return `Error` instead of supress the error here? src/tests/fetcher_tests.cpp (line 652) <https://reviews.apache.org/r/45057/#comment186904> Seems not all Linux distributions contains `zip` command. src/tests/fetcher_tests.cpp (line 674) <https://reviews.apache.org/r/45057/#comment186899> I suggest use `string` instead of `auto` here. src/tests/fetcher_tests.cpp (line 690) <https://reviews.apache.org/r/45057/#comment186902> Could you add comments why use this content? According my test, this content is a zip file which have contains two A file. src/tests/fetcher_tests.cpp (line 717) <https://reviews.apache.org/r/45057/#comment186900> Suggest use `string` instead of `auto` as well. - haosdent huang On March 18, 2016, 10:29 p.m., Tomasz Janiszewski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45057/ > ----------------------------------------------------------- > > (Updated March 18, 2016, 10:29 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4885 > https://issues.apache.org/jira/browse/MESOS-4885 > > > Repository: mesos > > > Description > ------- > > Made `unzip` overwrite existing files without prompting. > > > Diffs > ----- > > src/launcher/fetcher.cpp f85b118fb19cf9d4563f89847a783be35067e815 > src/tests/fetcher_tests.cpp fb47706eb90ae5808bafe13c681d609a808b0c8e > > Diff: https://reviews.apache.org/r/45057/diff/ > > > Testing > ------- > > > Thanks, > > Tomasz Janiszewski > >
