----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44081/#review124257 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp (lines 74 - 76) <https://reviews.apache.org/r/44081/#comment186714> We should make this a `namespace` similar to what we did for `Shell` in `shell.hpp`. 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp (line 78) <https://reviews.apache.org/r/44081/#comment186719> `s/process.lib/process.dll/`, right? 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp (line 79) <https://reviews.apache.org/r/44081/#comment186715> Once `Library` is a `namespace`, this should no longer be declared `static`. Here and below. 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp (line 118) <https://reviews.apache.org/r/44081/#comment186716> This is not necessarily `LD_LIBRARY_PATH` anymore, right? Here and below. 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp (line 131) <https://reviews.apache.org/r/44081/#comment186717> `setenv` in `stout/windows/os.hpp` is commented out and unimplemeneted. How does this work? - Michael Park On March 14, 2016, 9:10 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44081/ > ----------------------------------------------------------- > > (Updated March 14, 2016, 9:10 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > ------- > > Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp > 9ee233b988c08d953e70345c55bcdd5c2f7c101b > > Diff: https://reviews.apache.org/r/44081/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
